Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2312 SearchKit - Improve results loading time in admin UI #19426

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

colemanw
Copy link
Member

Overview

Per https://lab.civicrm.org/dev/core/-/issues/2312 this separates the ajax calls for fetching search results & the pager count for a snappier UX.

This addresses the issue on the admin screen but not yet for search displays, which need reworking anyway to go through a permissioned wrapper api.

Before

Single api call for rows & count might be very slow.

After

Fetch a page of results before loading pager count for asynchronous speed.

@civibot
Copy link

civibot bot commented Jan 20, 2021

(Standard links)

@civibot civibot bot added the master label Jan 20, 2021
@colemanw colemanw changed the title SearchKit - Separate api calls for results & pager count in admin screen dev/core#2312 SearchKit - Improve results loading time in admin UI Jan 22, 2021
@eileenmcnaughton
Copy link
Contributor

Thank you - this will improve the impression of it not working when the count request is slow

@eileenmcnaughton eileenmcnaughton merged commit 811baf1 into civicrm:master Jan 22, 2021
@eileenmcnaughton eileenmcnaughton deleted the searchCount branch January 22, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants