Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/financial#148 fully deprecate loadObjects function #19416

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

dev/financial#148 fully deprecate loadObjects function

Before

Function still in use

After

Function fully deprecated

Technical Details

the check for $success is meaningful as it either returns success or fails along the way

Comments

@civibot
Copy link

civibot bot commented Jan 18, 2021

(Standard links)

@monishdeb
Copy link
Member

Agree with the changes, tested on local, works fine.

@colemanw colemanw merged commit dca7262 into civicrm:master Jan 21, 2021
@colemanw colemanw deleted the dep branch January 21, 2021 02:32
@eileenmcnaughton
Copy link
Contributor Author

thanks @monishdeb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants