REF Ensure that when doing RLIKE BINARY the field is cast as BINARY t…

[seamuslee001]

…o prevent issue on MySQL 8

Overview

This fixes an error on MySQL 8.0.22 nativecode=3995 ** Character set 'utf8mb4_unicode_ci' cannot be used in conjunction with 'binary' in call to regexp_like.

Before

MySQL 8 errors

After

No Error

ping @demeritcowboy @eileenmcnaughton @totten

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Jenkins re test this please

[demeritcowboy]

I've only run on mariadb at the moment but just noting EXPLAIN is the same before and after, e.g. regarding performance. It depends more what the other fields in the select and where clauses are.

[eileenmcnaughton]

As soon as we are casting the field we will be bypassing the index - but we may already have been doing so.

How do we actually reach this clause?

[seamuslee001]

@eileenmcnaughton so its picked up by 2 tests at least https://test.civicrm.org/job/CiviCRM-Core-Edge/CIVIVER=master,label=test-3/lastCompletedBuild/testReport/(root)/api_v3_CustomValueTest/testCreateCustomValue/ https://test.civicrm.org/job/CiviCRM-Core-Edge/CIVIVER=master,label=test-3/lastCompletedBuild/testReport/(root)/CRM_Contact_SelectorTest/testWhereClauseByOperator/ and I think its done via Search Builder

[eileenmcnaughton]

I can't rule out that this will cause a performance regression in some cases but I don't think merging it is really optional given mysql8 can't be supported unless it works