(dev/wordpress#85) Fix version number reported within WordPress admin UI

[totten]

Overview

Updates distmaker so that WordPress zipballs include more accurate metadata about the Civi version.

More info: https://lab.civicrm.org/dev/wordpress/-/issues/85

Before

Only works if civicrm-wordpress:civicrm.php has the Version: header at the start of a line

After

Works with Version: header in an indented docblock.

Comments

Regressed in 5.33 due to code-cleanup in civicrm/civicrm-wordpress@ec410b08

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

cc @kcristiano @seamuslee001

[seamuslee001]

@totten I tested this with a local dist build

I can see it correctly set the version in the doc block but it seems the define is still stuck on 4.7

<?php
/**
 * Plugin Name: CiviCRM
 * Description: CiviCRM - Growing and Sustaining Relationships
 * Version: 5.34.beta1
 * Requires at least: 4.9
 * Requires PHP:      7.1
 * Author: CiviCRM LLC
 * Author URI: https://civicrm.org/
 * Plugin URI: https://docs.civicrm.org/sysadmin/en/latest/install/wordpress/
 * License: AGPL3
 * Text Domain: civicrm
 * Domain Path: /languages
 */

/*
 +--------------------------------------------------------------------+
 | Copyright CiviCRM LLC. All rights reserved.                        |
 |                                                                    |
 | This work is published under the GNU AGPLv3 license with some      |
 | permitted exceptions and without any warranty. For full license    |
 | and copyright information, see https://civicrm.org/licensing       |
 +--------------------------------------------------------------------+
 */

/**
 *
 * @package CRM
 * @copyright CiviCRM LLC https://civicrm.org/licensing
 *
 */

/*
 * -----------------------------------------------------------------------------
 * WordPress resources for developers
 * -----------------------------------------------------------------------------
 * Not that they're ever adhered to anywhere other than core, but people do their
 * best to comply...
 *
 * WordPress core coding standards:
 * https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/
 *
 * WordPress HTML standards:
 * https://make.wordpress.org/core/handbook/best-practices/coding-standards/html/
 *
 * WordPress JavaScript standards:
 * https://developer.wordpress.org/coding-standards/wordpress-coding-standards/javascript/
 * -----------------------------------------------------------------------------
 */

// This file must not accessed directly.
if (!defined('ABSPATH')) {
  exit;
}

// Set version here: when it changes, will force Javascript & CSS to reload.
define('CIVICRM_PLUGIN_VERSION', '4.7');

[seamuslee001]

@totten I found removing the space between the define( and the \' in the regex seemed to solve things here for me

[seamuslee001]

matches what I did locally Merge on pass

[kcristiano]

Since 5.33 is LTS I think we should backport this before the next release.