"Admin => Misc" - Fix validation of "Maximum File Size"

[totten]

Overview

The form "Administer => System Settings => Miscellaneous" has a field for "Maximum File Size".

I was on a workstation where the PHP-default and the Civi-default were disagreeable, so
(by default) I couldn't submit the form, which forced me to notice some quirks in the validation.

Before

• The error message tells you that the "Maximum File Size" disagrees with a setting in php.ini. Hopefully, you have SSH access so you can find and read PHP.ini (sic)... otherwise you'll be at a loss for what value is acceptable.
• The validation assumes that upload_max_filesize is expressed in unit-megabytes. But php.ini actually
  allows different units (2m, 2048k, 1g, 2097152). The comparison is incorrect
  if any other unit is used. (ex: If php.ini has upload_max_filesize=1g, and if the requested
  limit is 2 megabytes, then it should accept - but it rejects due to mismatched units.)

After

• Error message tells you what you need to know. Capitalization is correct.
• Validator correctly interprets the units used in php.ini's upload_max_filesize.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[demeritcowboy]

• General standards
  • [r-explain] PASS
  • [r-user] PASS
  • [r-doc] PASS
  • [r-run] PASS
• Developer standards
  • [r-tech] PASS
  • [r-code] Strangeness
    • Odd use of escaped quotes? And there's an extra space before the period at the end.
  • [r-maint] ____
  • [r-test] PASS
    • I also have a "webtest" that happens about once a week where I go to change something on dmaster.demo and I forget the default on this page there is 3 but php.ini on the demo server has 2, so I inadvertently do a basic test of the error message. I haven't put up a ticket to fix that because it's kind of good as a test, although the casual user might find it odd.

[eileenmcnaughton]

& @totten can you check @demeritcowboy's comment re quotes & comma & merge once addressed

[totten]

[T]here's an extra space before the period at the end.

Thanks. Fixed. ✅