Use php to require an array

[eileenmcnaughton]

Overview

Removes is_array check in favour of php strict typing

Before

lines of code to check if fileName is an array

After

strict typing

Technical Details

To be clear - there is no reason why it shouldn't be an array - in the bad old days a lot of error handling was put in to help developers who didn't have good debug tools

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

This looks good. Giving it a non-array throws a type error instead. It's an error not an exception, but gives the same result just with a different looking screen depending on your error handling settings.

Type error: Argument 1 passed to CRM_Activity_Import_Parser::run() must be of the type array, string given