[NFC] Fix Contribution Soft Credit entity translation #19351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Added a typo fix for "Recipientses" |
|
oh no - I just realized that these are auto-generated DAOs. Need to find how to fix in XML |
|
I updated the PR to fix a few XML files. Updating all xml files will take a while. For what it's worth, I understand why |
totten
added a commit
to totten/civicrm-core
that referenced
this pull request
Jan 11, 2021
This is a follow-up to civicrm#19351 to reflect recent changes in some schema files.
totten
added a commit
to totten/civicrm-core
that referenced
this pull request
Jan 11, 2021
This is a follow-up to civicrm#19351 which captures the spelling fix ("Recipientses").
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a string that is not valid English, and therefore confusing to translators.
Before / After
Entity "Contribution Softs" renamed to "Contribution Soft Credits".
ping @colemanw I think you may have added this string. Was there a length issue that required a shorter string?
Reported by @r4zoli on mattermost