Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept PHP memory_limit of -1 as meeting requirement #19340

Merged
merged 1 commit into from Jan 8, 2021
Merged

Accept PHP memory_limit of -1 as meeting requirement #19340

merged 1 commit into from Jan 8, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 7, 2021

A PHP memory_limit of '-1' is specified as 'unlimited'.

Before the change the checkmemory() function generates a Warning if the limit is set to -1. This shows up as a Warning in the Drupal Status Report, but more seriously also prevents the Drupal database update process (mydomain.com/update.php) from running.

After the change the value '-1' is accepted as meeting the requirement.

Overview

A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions.

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

A PHP memory_limit of '-1' is specified as 'unlimited'.

Before the change the checkmemory() function generates a Warning if the limit is set to -1.  This shows up as a Warning in the Drupal Status Report, but more seriously also prevents the Drupal database update process (mydomain.com/update.php) from running.

After the change the value '-1' is accepted as meeting the requirement.
@civibot
Copy link

civibot bot commented Jan 7, 2021

(Standard links)

@civibot civibot bot added the master label Jan 7, 2021
@demeritcowboy
Copy link
Contributor

xref: https://lab.civicrm.org/dev/core/-/issues/2289

  • General standards
    • [r-explain] PASS
    • [r-user] PASS
    • [r-doc] PASS
    • [r-run] PASS
      • Works for both -1 and a typical value.
  • Developer standards
    • [r-tech] PASS
    • [r-code] PASS
    • [r-maint] ____
    • [r-test] PASS

@seamuslee001 seamuslee001 merged commit a788e59 into civicrm:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants