Stop preventing test runs and dev sites from seeing PHP deprecation notices

[demeritcowboy]

Overview

PHP deprecations are hidden sometimes because of these lines. It seems to come from https://issues.civicrm.org/jira/browse/CRM-6327, which says "CiviCRM should automatically set E_DEPRECATED when running under PHP 5.3. Set this mode automatically to minimize support issues." In fairness, and I think I'm remembering now, it was a new constant, and by default live sites were including these notices if they had inherited the php 5.2 error_reporting settings, because the default was something like E_ALL & ~E_STRICT. These lines may have even been lifted verbatim from drupal 6.

You can reproduce the problem by using e.g. php 7.4 and setting your error_reporting to E_ALL and doing cv ev "$s = 'foo'; echo $s{0};". Before the patch you get no notice. After the patch you get the deprecation notice as you should.

Before

Even dev sites or test runs don't see deprecation notices sometimes, regardless of what you've set for error_reporting.

After

Notices appear depending on your error_reporting settings.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

It should go IMHO - if people don't have rights to set the error level I don't think we need to escalate it

[demeritcowboy]

Have updated description.

if people don't have rights to set the error level

I'm not fully sure what that means. I understand on some hosting you can't edit php.ini or .htaccess, but you can edit e.g. drupal settings.php or civicrm.settings.php to call error_reporting(). It might run after some very early booting, but it will be pretty early on.

[eileenmcnaughton]

OK I'm going to merge this - we are moving towards just expecting people to configure their own servers & not doing random stuff in core - which this aligns with. And it seems like some old weird legacy thing as you say

[demeritcowboy]

Noting this surfaced two more: #19350