dev/core#2285 Fix civicrm_alterReportVar hook for contribute detail r…

[ahed-compucorp]

Overview

The civicrm_alterReportVar is not working for contribute detail report.

Before

We're getting a "DB Error: no such field" when using the hook.

After

No Errors.

Technical Details

Here at Detail.php#L956 our changes to the _form attribute are lost and the error will be fired here Detail.php#L576

Unknown column 'some_table.some_column' in 'where clause'

Comments

Maybe it is not a good idea to fire the same hook twice so I am open to suggestions.
Adds test cover.

Issue: https://lab.civicrm.org/dev/core/-/issues/2285

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

In general I think this hook is highly flakey since the code could change and the hook might not always be able to interact in this same way. I always recommend people write their own report rather than use this hook to customise an existing one. However, I'm rather swayed by the included test on this specific PR.

I also note that the hope is to start to move away from these reports in favour of search-kit