Pledge: mark needed fields as required in schema #19309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This marks all the fields that are not optional as required. I've been having a bit of a battle adding
a v4 api & I hope this will help - but if not, it's correct for them to be marked required anyway
Before
Fields not identified as required , but they are
After
Fields marked required
Technical Details
As with the schema changes to financial type - there is still an outstanding upgrade script - I'll do both together once I've finalised #19296
Comments