Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pledge: mark needed fields as required in schema #19309

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jan 3, 2021

Overview

This marks all the fields that are not optional as required. I've been having a bit of a battle adding
a v4 api & I hope this will help - but if not, it's correct for them to be marked required anyway

Before

Fields not identified as required , but they are

After

Fields marked required

Technical Details

As with the schema changes to financial type - there is still an outstanding upgrade script - I'll do both together once I've finalised #19296

Comments

This marks all the fields that are not optional as required. I've been having a bit of a battle adding
a v4 api & I hope this will help - but if not, it's correct for them to be marked required anyway
@civibot
Copy link

civibot bot commented Jan 3, 2021

(Standard links)

@civibot civibot bot added the master label Jan 3, 2021
@eileenmcnaughton
Copy link
Contributor Author

test this please

@colemanw
Copy link
Member

colemanw commented Jan 4, 2021

@eileenmcnaughton I'm happy to merge this but it definitely needs the upgrade script and we're about to branch RC.

@colemanw colemanw merged commit 6ac6149 into civicrm:master Jan 4, 2021
@colemanw colemanw deleted the pledge_req branch January 4, 2021 20:37
@eileenmcnaughton
Copy link
Contributor Author

Update script in update script in #19335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants