fix email receipt flag for recurring record

[eileenmcnaughton]

Overview

Reviewer's commit of #19210

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[yashodha]

@eileenmcnaughton

are the failing tests related?

[eileenmcnaughton]

@yashodha the 2 membership tests were a once-a-year-bug in the tests I think (also affect the other runs). the other is in the new test but didn't fail locally & could also be a new-years's bug. I've pushed up a cleanup patch which will trigger the tests to run again so we can see

[demeritcowboy]

jenkins test this please

[eileenmcnaughton]

test this please

[sunilpawar]

@eileenmcnaughton

CRM_Contribute_BAO_ContributionRecurTest::testContributionEmailReceipt
ERROR USERINFO: INSERT INTO civicrm_contribution_recur (contact_id , amount , currency , frequency_unit , frequency_interval , installments , start_date , create_date , modified_date , end_date , processor_id , contribution_status_id , is_test , cycle_day , next_sched_contribution_date , failure_count , auto_renew , payment_processor_id , financial_type_id , payment_instrument_id ) VALUES ( 46 , 3 , 'USD' , 'week' , 1 , 2 , 0 , 0 , 0 , 0 , '643411460836' , 1 , 0 , 1 , 0 , 0 , 0 , 1 , 1 , 1 ) [nativecode=1292 ** Incorrect datetime value: '0' for column 'start_date' at row 1]

[eileenmcnaughton]

@sunilpawar does it fail there locally for you? It didn't for me yesterday - I'm wondering if there is a mysql config in play (@demeritcowboy does this seem familiar?)

[demeritcowboy]

I think the test failure is just that the add() function doesn't take this type of params. The params format seems intended for the api which converts relative dates like 'yesterday' into actual dates. If you give that to add() then it tries to literally insert 'yesterday' into a date field.

[eileenmcnaughton]

Ok - I fixed it up to call the api - hopefully it passes now