dev/core#2206 Move cancel pledge into Contribution.create and fix #19289
Conversation
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
cancel
branch
from
eec6765 to
178c5df
Compare
eileenmcnaughton
force-pushed
the
cancel
branch
2 times, most recently
from
cfbbdb7 to
a0e20a8
Compare
Per https://lab.civicrm.org/dev/core/-/issues/2206 I think updating pledge payments is a data issue rather than a business process issue. Notably you can't record a new contribution against the pledge unless the existing one is removed This is the last thing that needs to be done before we can unhide contributioncancelactions
eileenmcnaughton
force-pushed
the
cancel
branch
from
a0e20a8 to
e26d0d2
Compare
|
@seamuslee001 @mattwire with the Pledge & PledgePayment apis now merged this is passing. It is the last thing I think we need to do before unhiding contributioncancelactions |
|
@monishdeb @JoeMurray this is a PR that would be good to get reviewed if possible - it's the penultimate PR for issue 2206 |
|
I have reviewed the patch and run on my local. Looks good to me. It updates the pledge payment with Pending status. The added Unit Test successfully captures the cancellation process. @eileenmcnaughton I was thinking without disconnecting the contribution, will it be better to to still keep the mapping for historical reference, in a way that it doesn't affect the instalment? |
|
@monishdeb that feels like a scope creep that I would probably leave well enough alone unless we get a request |
|
Agree. Well then I am happy to merge this PR, as it rightfully moves the pledge payment processing code as a result of cancelling the associated contribution, inside Contribution.create. |
With civicrm#19289 merged we can now unhide this extension & people can disable it if they wish (as a supported option)
|
I've added a PR to unhide this - the last step to resolve https://lab.civicrm.org/dev/core/-/issues/2206 |
With civicrm#19289 merged we can now unhide this extension & people can disable it if they wish (as a supported option)
Overview
dev/core#2206 Move cancel pledge into Contribution.create and fix
Before
Cancelling (or failing) a contribution does not properly update the pledge payment, such that it can have a new contribution added to it.
After
When the contribution is cancelled the contribution id is removed from any pledge payments, they are updated to be pending again & actual_amount is unset
Technical Details
Per https://lab.civicrm.org/dev/core/-/issues/2206 I think updating pledge payments is a data issue
rather than a business process issue. Notably you can't record a new contribution against the pledge
unless the existing one is removed
Comments
This is the last thing that needs to be done before we can unhide contributioncancelactions