Add index on civicrm_group.cache_date #19288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per civicrm#19287 I also considered an index on refresh_date but I couldn't see any evidence the field is useful
|
(Standard links)
|
mattwire
added
the
merge ready
|
I think this is ok |
|
Been merge ready for long enough and I don't think there would be a problem with this merging |
wmfgerrit
pushed a commit
to wikimedia/wikimedia-fundraising-crm
that referenced
this pull request
Jan 8, 2021
See civicrm/civicrm-core#19288 - we should be able to rely on core to set these on new installs going forwards It's not terrbily important for dev installs to have the right indexes anyway as lack of data means they dont' really kick in Bug: T270680 Change-Id: If5eb428c6ae576f752e1e1fcc635a207da2509f6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add index on civicrm_group.cache_date
Before
civicrm_group.cache_date used in where clauses but no index
After
Indexed on new installs
Technical Details
Per #19287 I also considered an index on refresh_date but
I couldn't see any evidence the field is useful
Comments