Move financial acl warning from FinancialType BAO to extension. #19283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
It turns out this is not currently triggered by the api as the api passes in the key FinancialType in ids and it is looking for financialType. Regardless I think this makes sense in the extension and setting in the session as currently sometimes works makes sense (at least enough to move rather than remove)
eileenmcnaughton
force-pushed
the
facl
branch
from
8e36f40
to
d646594
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Move financial acl warning from FinancialType BAO to extension.
Before
When renaming a financial type a warning is saved in the session to indicate that it may invalidate existing financial acls (if enabled). This is in the FinancialType BAO. It does not work via the api.
After
Code moved to the financial acls extension as a pre hook, works via the api too.
Technical Details
It turns out this is not currently triggered by the api as the api passes in the key FinancialType in
ids and it is looking for financialType. This is actually fixed in this PR
Setting in the session as currently sometimes works makes sense (at least enough to
move rather than remove).
Also I had to add pre & post hooks for this. As part of our rationalise-to-create push I put this in a new create function & commented the intent to deprecate & remove add. There are a few existing calls to add but mostly in unit tests - one is fixed in #19282
Comments