Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIv4 - Smarter check for adding default ON clause to explicit joins #19275

Merged
merged 1 commit into from
Dec 28, 2020
Merged

APIv4 - Smarter check for adding default ON clause to explicit joins #19275

merged 1 commit into from
Dec 28, 2020

Commits on Dec 24, 2020

  1. dev/core#2271 - APIv4 - Smarter check for adding default ON clause to… 

    … explicit joins

When adding explicit joins in APIv4, the API will automacially add an ON clause linking it
to the base entity unless it detects some other link already present in the ON clause supplied.
Previously it would determine this by checking for the join entity ID;
now it looks for the join entity ID OR any other field in the join entity with an FK.
This gives more leeway for people to add creative joins without the defaults getting in the way.
    @colemanw
    colemanw committed Dec 24, 2020
    Configuration menu
    Copy the full SHA
    a5d7af6 View commit details
    Browse the repository at this point in the history