dev/core#2240 - Convert remaining two deprecatedWarning calls

[demeritcowboy]

Overview

Follow-on to #19179. Converts remaining two civi.tag-deprecated to central function.

Technical Details

I left these out of the previous PR these mostly because I wasn't sure if these are deprecations or they should be actual exceptions. I'm still not sure.

The first one I can sort of see the argument if the system still functions without it.

The second one though I think there's a stronger reason to throw an exception instead, since it's 4 years old, and if there are still undeclared modules that seems like a real error now. Also, on a smaller note, for this one either way the concept of placeholders isn't supported so I've flattened the string.

So I dunno. I've left them as deprecations for now, but if people agree they should be exceptions instead it's an easy change.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

My feeling is that this PR is correct for these two @eileenmcnaughton thoughts?

[eileenmcnaughton]

I think we should throw an exception in the latter case - the goal is that deprecations hang around for 6-12 months in most cases. 4 years is quite a while.

[demeritcowboy]

Thanks!