Improve logging when a contribution is created/updated

[mattwire]

Overview

When a contribution is created in CiviCRM up to 3 log messages are created. Compared with other actions in CiviCRM this is very verbose (ie. most things don't log anything by default). The messages that are logged are not very useful because they don't give enough information to use them for forensics/debugging:

1. Contribution record updated successfully
2. Receipt sent
3. Success: Database updated

This PR removes the 3rd one entirely and updates the first two messages to include the contribution ID making them far more useful:

Contribution {$contributionParams['id']} updated successfully
Contribution {$contributionParams['id']} Receipt sent

Before

1. Contribution record updated successfully
2. Receipt sent
3. Success: Database updated

After

Contribution {$contributionParams['id']} updated successfully
Contribution {$contributionParams['id']} Receipt sent

Technical Details

Explained above.

Comments

These have annoyed me for a while as they are are often found in the logs but are not very helpful...

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

This looks good to me makes sense to me merging