Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error on contribution summary report (and probably others) when adding contacts to group #19250

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

jitendrapurohit
Copy link
Contributor

Overview

Fatal error on contribution summary report (and probably others).

Before

To replicate

  • Make sure ONLY_FULL_GROUP_BY mode is enabled in mysql.
  • Load contribution summary report, enable contact name and search.
  • Select the action to add contacts to one of the groups.

image

After

No error, the contacts are added to the group.

Technical Details

Query stilll the same, we've disabled the full group by mode for the reports that are not optimized to work with this mode.

Comments

Gitlab - https://lab.civicrm.org/dev/core/-/issues/2265

@civibot
Copy link

civibot bot commented Dec 21, 2020

(Standard links)

@civibot civibot bot added the master label Dec 21, 2020
@eileenmcnaughton
Copy link
Contributor

thanks @jitendrapurohit - this is consistent with changes made elsewhere

@seamuslee001 seamuslee001 merged commit 41dbb7d into civicrm:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants