Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Relocate another deprecated utils function to the only class that calls it. #19248

Merged
merged 1 commit into from
Dec 23, 2020
Merged

[REF] Relocate another deprecated utils function to the only class that calls it. #19248

merged 1 commit into from
Dec 23, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Dec 21, 2020 •
edited
Loading

Overview

[REF] Relocate another deprecated utils function to the only class that calls it

Before

Function sits in the old deprecated utils file

After

Function sits in the one class that calls it

Technical Details

I removed the tests because they didn't test much & what they did test
seemed like stuff we should alter

Comments

@civibot
Copy link

civibot bot commented Dec 21, 2020

(Standard links)

@civibot civibot bot added the master label Dec 21, 2020
@eileenmcnaughton eileenmcnaughton changed the title [REF] Relocate another deprecated utils function to the only class th… [REF] Relocate another deprecated utils function to the only class that calls it. Dec 21, 2020
@eileenmcnaughton
Copy link
Contributor Author

test this please

1 similar comment
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton
[REF] Relocate another deprecated utils function to the only class th…
4abeee3 
…at calls it.

I removed the tests because they didn't test much & what they did test
seemed like stuff we should alter
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 this has passed now - the same as the others you have merged

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 once this is merged I'll look at the next step on the import cleanup

@seamuslee001
Copy link
Contributor

Looks fine to me merging

@seamuslee001 seamuslee001 merged commit 23c0262 into civicrm:master Dec 23, 2020
@seamuslee001 seamuslee001 deleted the dep_utils branch December 23, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001