Search kit: Rewrite input widget to support IN sets, relative dates, BETWEEN groups, etc. #19229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
force-pushed
the
searchKitInput
branch
2 times, most recently
from
3545265
to
31ab4f3
Compare
…BETWEEN groups, etc. This deletes the crmSearchValue widget (and the now-empty crmSearchKit module), which had originally been copied from the API Explorer, and replaces it with a more flexible set of components with separate templates for each data type.
colemanw
force-pushed
the
searchKitInput
branch
from
31ab4f3
to
014174e
Compare
|
This only affects searchkit which remains fast moving code. I'm testing intermittently rather than each PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This overhauls the input widget for all fields in Search Kit.
Before
Single input widget.
After
Flexible widget supports relative dates, date ranges,
INandNOT INsets, and a range selector forBETWEEN.Technical Details
This deletes the
crmSearchValuedirective (and the now-emptycrmSearchKitmodule), which had originally been copied from the API Explorer, and replaces it with a more flexible set of components with separate templates for each data type.