Remove duplicated tax assignments from copied code

[eileenmcnaughton]

Overview

Remove duplicated tax assignments from copied code

Before

Tax data for the template being assigned twice in the recurring payment for membership back-office form flow. The instance being removed is from a previously shared function - very little of which is actually relevant to this form

  $smarty->assign('dataArray', $dataArray);
        $smarty->assign('totalTaxAmount', $params['tax_amount'] ?? NULL);

After

poof

Technical Details

The assignment of tax data is happening twice on the form - once in generic
code and once in code only reached for recurring contributions that
was in previously-shared code. We can be fairly comfortable that
in this latter case we don't need it as this is a marginal flow
on this form whereas the main flow is being used 90% of the time
& is doing the assignment

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

This seems fine to me merging