Move processConfirm function from Utils file back to form class #19212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using it This function is really part of the Confirm form. People thought sharing it would be good once. They were wrong. More specifically sharing large blocks of code that attempt to service many diferent needs is not helpful
|
(Standard links)
|
eileenmcnaughton
changed the title
|
Test coverage would show us if there is some issue here merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Move processConfirm function from Utils file back to only form still using it
Before
Large processing function only called by the confirm form, but located on a different class
After
Function moved to the Confirm the form class
Technical Details
This function is really part of the Confirm form. People thought sharing it would
be good once. They were wrong.
More specifically sharing large blocks of
code that attempt to service many diferent needs is not helpful
Comments