dev/core#2242 Ensure that when a custom field is deleted any associat…

[seamuslee001]

…ed mapping field records are also deleted to avoid DB errors when doing exports

Overview

Does what it says above

Before

Possible DB error if re-using a saved field mapping for export which contains a reference to a custom field that has been deleted

After

No DB error

Technical Details

I suspect we will want to use an Upgrade to clean up stuff here as well

ping @eileenmcnaughton @jusfreeman

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton @jusfreeman I've added an upgrade routine now as well

[eileenmcnaughton]

Cool - @agileware-justin I think you reported this - will you review @seamuslee001 work on it?

[agileware-justin]

Yep will do, thanks again @seamuslee001 and for the ping @eileenmcnaughton

[agileware-justin]

I really like having an upgrade script to fix pre-existing issues for this problem. Nice one!

[agileware-justin]

Related Gitlab issue for anyone wondering, https://lab.civicrm.org/dev/core/-/issues/2242

[eileenmcnaughton]

@seamuslee001 please self-merge when @agileware-justin confirms - code looks good & test looks extra good

[seamuslee001]

@agileware-justin has someone from your team been able to review / test this?

[agileware-justin]

@seamuslee001 I did try to test it on CiviCRM 5.32.2 but the patch didn't apply.

Is this for CiviCRM 5.34? If so then I'll need to test against https://download.civicrm.org/latest/civicrm-NIGHTLY-wordpress.zip

We break for Xmas hols from 18/12, so it's only me who would have time to test it during the holidays.

[seamuslee001]

@agileware-justin yes that would be correct

[agileware-justin]

PR for #civicrm-5.34.0