Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure to assign view tpl variables to view page if context=search is in the url #19189

Merged
merged 1 commit into from
Dec 12, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Dec 12, 2020

Overview

Fixes a regression where the participant view screen was not displaying correctly if context=search is in the url - which it current is when accessing the screen from search results

Before

Screenshot from 2020-12-12 15-46-16

After

Screenshot from 2020-12-12 15-47-28

Technical Details

I suspect a url change inadvertantly triggering it to treat the mode as edit has been at the root of what we've been seeing. I want to fix properly in master

Comments

Whack-a-mole round 10

@civibot
Copy link

civibot bot commented Dec 12, 2020

(Standard links)

@civibot civibot bot added the 5.33 label Dec 12, 2020
@eileenmcnaughton eileenmcnaughton changed the title Fix failure to assign view tpl variables to view page if context=sear… Fix failure to assign view tpl variables to view page if context=search is in the url Dec 12, 2020
@demeritcowboy
Copy link
Contributor

I'm not sure how I did it - will follow up tomorrow - but INSERT INTO civicrm_financial_item (transaction_date , contact_id , de...", "1292 ** Incorrect datetime value: '0' for column 'transaction_date' at row 1" and there was something weird about the javascript for the record payment checkbox.

but in terms of viewing the details and the save/etc buttons it seems to work. Thanks!

@seamuslee001
Copy link
Contributor

I'm going to merge this based on @demeritcowboy 's testing

@seamuslee001 seamuslee001 merged commit 26b2f32 into civicrm:5.33 Dec 12, 2020
@seamuslee001 seamuslee001 deleted the 533q1 branch December 12, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants