Switch to non-static functions

[eileenmcnaughton]

Overview

Switch to non-static functions

Before

Functions used only by the form objects are static - this appears to be in order to use them from formRule

After

Functions non-static. Form rule calls them on the form object it was passed. Note this is rather more powerful as it can potentially access & set properties. This means that a property may not need to be fetched as many times

Technical Details

I realise these functions are static so that the formRule can call them - but
the formRule has access to the form object and the intention was obviously always
that the formRule can call functions on the form. This cleans that up:

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[demeritcowboy]

I was just looking at this. Agree the fail seemed like a glitch.

r-run: Did a quick run. Had some weirdnesses but I don't think it's related to the PR. Otherwise ok.
r-code: I think the ?array is ok since php 7.1 is the minimum supported.

Looks good.

[eileenmcnaughton]

@seamuslee001 - this has review by @demeritcowboy (thanks @demeritcowboy !)