Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extensions tabs following deprecation of old tab code #19130

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Dec 5, 2020

Overview

Fix extensions tabs following changes in #19066

Before

Tabs stopped rendering on extensions page.

After

Tabs load and selectedChild works.

Technical Details

Add tab javascript resource.

Comments

@demeritcowboy @colemanw This is the fix I think!

@civibot
Copy link

civibot bot commented Dec 5, 2020

(Standard links)

@demeritcowboy
Copy link
Contributor

Thanks. Works for me!

@seamuslee001 seamuslee001 merged commit 812fd9f into civicrm:master Dec 5, 2020
@eileenmcnaughton
Copy link
Contributor

@mattwire @demeritcowboy - quick work! Can you confirm

  1. can we close the issue
  2. this is against master - should it be against the rc (which was only cut a few days ago)

@demeritcowboy
Copy link
Contributor

The other PR was merged yesterday so it's just master.

The lab ticket can close just needs a milestone - doesn't seem to be a 5.34 available.

@eileenmcnaughton
Copy link
Contributor

Created - @mlutfy can we make it so Dave can create milestones?

@mlutfy
Copy link
Member

mlutfy commented Dec 6, 2020

@eileenmcnaughton On Gitlab or Github? (Gitlab should be easy, but I don't know for Github)

@demeritcowboy
Copy link
Contributor

Gitlab. An alternative is add it to the release tasklist to create a new label for whatever the new master is. Not sure where that list/script lives. Maybe this should be its own ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants