Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to check pcp notification is sent #19117

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Add test to check pcp notification is sent #19117

merged 2 commits into from
Dec 8, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

unit test In support of
#19096

Before

Test cover missing, no PcpBlock v4 api

After

tada

Technical Details

I wound up adding PcpBlock v4 api to help me write the test

Comments

@civibot
Copy link

civibot bot commented Dec 4, 2020

(Standard links)

@civibot civibot bot added the master label Dec 4, 2020
@eileenmcnaughton eileenmcnaughton mentioned this pull request Dec 4, 2020
Closed
@eileenmcnaughton
Add test to check pcp notification is sent
da508f6 
I wound up adding PcpBlock v4 api to write the test

In support of
civicrm#19096
@eileenmcnaughton
Add test to check pcp notification is sent
f6992e7 
I wound up adding PcpBlock v4 api to write the test

In support of
civicrm#19096
@seamuslee001
Copy link
Contributor

Looks good to me

@seamuslee001 seamuslee001 merged commit aae3220 into civicrm:master Dec 8, 2020
@seamuslee001 seamuslee001 deleted the test_find branch December 8, 2020 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001