Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Kit: Support robust joins in UI #19105

Merged
merged 1 commit into from
Dec 5, 2020
Merged

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Dec 4, 2020

Overview

Vastly improves support for joins in the Search Kit UI.

Before

Only a few joins supported, others appeared to work but would fail due to ambiguities in the multiple ways 2 entities can be joined.

After

This uses better join metadata to give explicit conditions for each join, removing the ambiguity when more than one type of join is possible between the same 2 entities.
It also adds support for joins via EntityBridge APIs.

This uses better join metadata to give explicit conditions for each join,
removing the ambiguity when more than one type of join is possible between the same 2 entities.
It also adds support for joins via EntityBridge APIs.
@civibot
Copy link

civibot bot commented Dec 4, 2020

(Standard links)

@civibot civibot bot added the 5.33 label Dec 4, 2020
@colemanw colemanw marked this pull request as draft December 4, 2020 00:33
@eileenmcnaughton
Copy link
Contributor

@colemanw given we are still stabilising search kit and this only touches files in there my preference is that you merge this as soon as you are happy with it and then we start a round of testing / tire kicking. As discussed an rc merge is ok as the deadline has just snuck by and this is very much building on work in progress and will make the process of testing it much easier

@colemanw colemanw marked this pull request as ready for review December 5, 2020 00:31
@colemanw colemanw merged commit 695b6f3 into civicrm:5.33 Dec 5, 2020
@colemanw colemanw deleted the searchJoins branch December 5, 2020 00:35
@colemanw
Copy link
Member Author

colemanw commented Dec 5, 2020

Ok merging it.
There's a few loose ends I'd like to tie up, such as supporting multiple levels of join. Will try to put together a folloup PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants