Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContributionSoft v4 api #19083

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Dec 1, 2020

Overview

Add ContributionSoft v4 api

Before

Just empty space

After

Tada

Technical Details

Very standard

Comments

@civibot
Copy link

civibot bot commented Dec 1, 2020

(Standard links)

@civibot civibot bot added the master label Dec 1, 2020
@colemanw
Copy link
Member

colemanw commented Dec 1, 2020

I think the test data just needs to include a dummy contribution.

@eileenmcnaughton
Copy link
Contributor Author

@colemanw I looked at the test & can't see where it's creating dummy data - does it just rely on default test data (in which case I'd need to add a setUp routine and create one & tear it down)

I also note the test just throws 'Exception' - our standard is to throw CRM_Core_Exception if we don't have something more specific - is there any reason not to change to that?

@colemanw
Copy link
Member

colemanw commented Dec 3, 2020

I think you'd add it here: https://github.com/civicrm/civicrm-core/blob/master/tests/phpunit/api/v4/DataSets/ConformanceTest.json

Core exception sounds fine to me.

@eileenmcnaughton
Copy link
Contributor Author

@colemanw OK passing now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants