dev/financial#157 [REF] Extract functions

[eileenmcnaughton]

Overview

This is just preliminary cleanup - extract a couple of functions in the payment processor form for readability

Before

long block

After

Extracted

Technical Details

Pretty basic

Comments

@mattwire I took a look at the form in conjunction with https://lab.civicrm.org/dev/financial/-/issues/157 & had 2 thoughts about how to make the change / improve the form

1. I don't think the form needs to / should inherit from CRM_Admin_Form - that seems just a bit legacy & worth breaking
2. we need to know the payment processor type before setEntityFields is called to move the handling to that function. I feel like we can do that if we support an extra function on the trait ie

diff --git a/CRM/Core/Form/EntityFormTrait.php b/CRM/Core/Form/EntityFormTrait.php
index 5ebf4441e8..de96db70a4 100644
--- a/CRM/Core/Form/EntityFormTrait.php
+++ b/CRM/Core/Form/EntityFormTrait.php
@@ -247,6 +247,7 @@ trait CRM_Core_Form_EntityFormTrait {
    * translation or other non-input specific handling.
    */
   protected function setTranslatedFields() {
+    $this->prepareForm();
     $this->setEntityFields();

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 can you merge this - it's pretty trivial

[seamuslee001]

Yeh this seems fine to me