Extract function that generates upgrade link for extensions #19070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@mattwire I'm going to take a look at this and review it on it's merits & presumably merge it. However, I note you are doing a bunch of work on the extensions UI - we have previously discussed bringing the extensions ui extension that exists into core as a core-extension and leaping to that and deprecating the existing UI and likely will do this as some point- so it might be better to look at that to ensure your work doens't wind up deprecated? |
|
@mattwire aha I found it https://github.com/twomice/org.civicrm.extensionsui |
|
@seamuslee001 I was many seconds ahead of you :-) |
|
I gave the code a quick skim and it seemed sensible so I gave it an r-run & it worked - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Extract function that generates extension upgrade link. It was being generated in two places - for env check and for extensions dir.
On the extensions directory it is not very "UI friendly" to display the "upgrade available" on extensions that are not installed and a follow up PR will allow us to show a different message in this case. Also, I'd like to introduce a mgmt tag to disable the upgrade option which can be applied when using custom versions of an extension (ie. patched versions).
Before
Upgrade links generated in multiple places (environment check + extension dir template).
After
Upgrade link generated in one place.
There is a small change in this PR - we are no longer showing the extension key in brackets after the extension name - that follows on from the change we made in #18981.
Technical Details
Comments