dev/financial#148 fold call to loadObjects #19033
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Copy loadObjects into IPN function rather than calling it - this is towards removing the code per https://lab.civicrm.org/dev/financial/-/issues/148
Before
loadObjects called - appears to be 'dry' but in fact it has little code in it & it increases rather than decreases complexity
After
Code duplicated - with an eye to further removal & cleanup
Technical Details
Comments