Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend test to cover membership logs #19023

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Extend test to cover membership logs #19023

merged 1 commit into from
Dec 8, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Nov 23, 2020 •
edited
Loading

Overview

Minor test extension to support switching to the api on membership save in transition components

Before

Log entries not tested

After

Log entries tested

Technical Details

Generally I think we can switch to using the api here

Comments

@civibot
Copy link

civibot bot commented Nov 23, 2020

(Standard links)

@civibot civibot bot added the master label Nov 23, 2020
@seamuslee001
Copy link
Contributor

Looks like it might be via api_v3_ContributionTest::testPendingToCompleteContribution but not 100% sure

@eileenmcnaughton eileenmcnaughton changed the title Test whether the activity change is tested Extend test to cover membership logs Nov 23, 2020
@colemanw colemanw merged commit 9dc7c39 into civicrm:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @seamuslee001 @colemanw