Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2197 Deploy monaco-editor using composer.json / composer dow… #18988

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

seamuslee001
Copy link
Contributor

…nloads method

Overview

This installs the javascript package monaco-editor that is needed for afform-html using composer downloads rather than needing npm

Before

Need npm to install necessary javascript package

After

Installed using composer downloads package

ping @totten

@civibot
Copy link

civibot bot commented Nov 18, 2020

(Standard links)

@civibot civibot bot added the master label Nov 18, 2020
@totten
Copy link
Member

totten commented Nov 18, 2020

  • r-run: Did a quick local build/run, and it worked. 👍
  • r-code: Since responsibility has moved to composer.json, can we remove all the npm bits to prevent confusion (eg ext/afform/html/package*json and ext/afform/html/bin/setup.sh)? (Note: I think we could get rid of html/bin/setup.sh completely since there's no more intent to distribute separate tarballs.)

If we address the stale npm bits, then MOP.

…nloads method

Remove setup.sh as no longer needed and npm related package files
@seamuslee001
Copy link
Contributor Author

Ok have updated that now adding MOP tag based on @totten 's comment

@totten totten merged commit 07340f3 into civicrm:master Nov 19, 2020
@seamuslee001 seamuslee001 deleted the dev_core_2197 branch November 19, 2020 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants