Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Remove always FALSE variable from transitionComponents #18983

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Nov 17, 2020

Overview

[REF] Remove always FALSE variable from transitionComponents

Before

public static function transitionComponents($params, $processContributionObject = FALSE) {

but second parameter is never passed in

Screenshot from 2020-11-17 14-40-23
Screenshot from 2020-11-17 14-40-43

After

poof

public static function transitionComponents($params) {

Technical Details

This is not ever passed in now we have removed the call from membership form

I've kept this PR restricted to changes in transitionComponents
since that means the main reviewer task is to confirm the
paramter is never passed in & hence is false, but
quite a lot of other stuff can be ripped out as follow ups

Comments

This is not ever passed in now we have removed the call from membership form

I've kept this PR restricted to changes in transitionComponents
since that means the main reviewer task is to confirm the
paramter is never passed in & hence is false, but
quite a lot of other stuff can be ripped out as follow ups
@civibot
Copy link

civibot bot commented Nov 17, 2020

(Standard links)

@civibot civibot bot added the master label Nov 17, 2020
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 next minor one of these

@seamuslee001
Copy link
Contributor

I did a grep around the universe and the only place that originally passed this in was on the back office membership form which has been removed merging

@seamuslee001 seamuslee001 merged commit ea73aca into civicrm:master Nov 19, 2020
@seamuslee001 seamuslee001 deleted the trans branch November 19, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants