Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undeclared afform requirement of ngRoute #18975

Merged
merged 1 commit into from
Nov 15, 2020
Merged

Fix undeclared afform requirement of ngRoute #18975

merged 1 commit into from
Nov 15, 2020

Conversation

colemanw
Copy link
Member

Overview

Fixes a crash when embedding an afform directive on other Angular pages.

Before

Afform dependency ngRoute fails to load.

After

Works correctly.

@civibot
Copy link

civibot bot commented Nov 15, 2020

(Standard links)

@civibot civibot bot added the master label Nov 15, 2020
@seamuslee001
Copy link
Contributor

Looks fine to me

@seamuslee001 seamuslee001 merged commit 6106e5a into civicrm:master Nov 15, 2020
@seamuslee001 seamuslee001 deleted the fixAfformDep branch November 15, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @seamuslee001