Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi-value contact reference custom fields #18941

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Nov 6, 2020

Overview

Allows custom fields of type ContactReference to be multi-valued. See also https://lab.civicrm.org/dev/core/-/issues/2123

Before

Contact reference fields must be single-valued.

After

Multi-valued contact reference custom fields supported.

@civibot
Copy link

civibot bot commented Nov 6, 2020

(Standard links)

@michaelmcandrew
Copy link
Contributor

@colemanw - I have tested this in a few scenarios and it is working nicely for the client. I think it is ready to merge.

@michaelmcandrew michaelmcandrew marked this pull request as ready for review December 3, 2020 12:25
@michaelmcandrew
Copy link
Contributor

  • General standards
    • (r-explain) Pass
    • (r-user) Pass: This is opt in. No change for existing users.
    • (r-doc) Pass
    • (r-run) Pass: I have tested this for a week on a client site, including data entry and advanced search. Came across some issues early on which were then fixed and tested in a subsequent round of testing.
  • Developer standards
    • (r-tech) Pass: Written by Coleman extending usage of a pre-existing pattern, so likely safe.
    • (r-code) Pass
    • (r-maint) Pass
    • (r-test) Pass: Includes some new tests.

@colemanw colemanw changed the title [WIP] Add support for multi-value contact reference custom fields Add support for multi-value contact reference custom fields Dec 3, 2020
@colemanw colemanw merged commit f05237f into civicrm:master Dec 8, 2020
@colemanw colemanw deleted the multiValueContactRef branch December 8, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants