dev/core#2166 - E_NOTICE when deleting mail account

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/2166

1. Create a mail account at Administer - CiviMail - Mail Accounts.
2. Make sure to choose Email-to-Activity for the Used For field or else the delete link won't be available (this seems partly like a historical mixup which I'm not going to get into here).
3. Save it.
4. Now click the delete link to delete it.

Before

Notice: Undefined index: domain in CRM_Admin_Form_MailSettings::formRule() (line 129 of ...\CRM\Admin\Form\MailSettings.php).

After

Technical Details

Just wraps the validation in an if to see if we're deleting first. The rest is because the function doesn't have enough input to check that as currently written.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Makes sense.