Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#2154 Fix the output of the full text custom search form #18890

Merged
merged 1 commit into from
Oct 31, 2020
Merged

dev/core#2154 Fix the output of the full text custom search form #18890

merged 1 commit into from
Oct 31, 2020

Conversation

seamuslee001
Copy link
Contributor

Overview

This is a companion to #18889 which fixed the style problems Dave D has noted

Before

ft_before

After

ft_after

ping @demeritcowboy @eileenmcnaughton

@civibot civibot bot added the 5.31 label Oct 30, 2020
@civibot
Copy link

civibot bot commented Oct 30, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

@demeritcowboy happy with this? Good to merge if so

@demeritcowboy
Copy link
Contributor

Ok to merge. Tested on drupal 7 and drupal 8. Looks good. Interestingly on drupal 8 it was still ok before.

Noticing also the drupal sidebar block looks a little screwy but that's enough for today and not sure when that started.

@seamuslee001 seamuslee001 merged commit 5f6708d into civicrm:5.31 Oct 31, 2020
@seamuslee001 seamuslee001 deleted the dev_core_2154 branch October 31, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.31 merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seamuslee001 @eileenmcnaughton @demeritcowboy