dev/financial#152 move code only relevant to repeattransaction into that function

[eileenmcnaughton]

…

Overview

Per #18814 I dug into this addRecurSoftCredits and
it simply copies soft credits from the first transaction in the series to the new one. As such
it belongs in repeattransaction not the main body of completeOrder

Before

// Add new soft credit against current $contribution.
    if ($recurringContributionID) {
      CRM_Contribute_BAO_ContributionRecur::addrecurSoftCredit($recurringContributionID, $contributionID);
    }

is in the main flow

After

Above is in the repeattransaction specific flow

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[seamuslee001]

Looks fine to me