[REF] Extract handling for loading contribution recur object. #18746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
We actually load this multiple times.... This alters one of the retrievals to make it more re-usable and removes the duplicate validation
| if (!$ids['contributionRecur']) { | ||
| $message = ts("Could not find contributionRecur id"); | ||
| $log = new CRM_Utils_SystemLogger(); | ||
| $log->error('payment_notification', ['message' => $message, 'ids' => $ids, 'input' => $input]); |
There was a problem hiding this comment.
is removing the additional debugging information an issue here?
There was a problem hiding this comment.
@seamuslee001 yeah - I commented on that in the pr template - I'm inclined to 'no' as I can't recall the last ticket referencing that output & if the answer were yes I think the catch would be a better place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We actually load this multiple times.... This alters one of the retrievals to make it more re-usable
as a step towards consolidatio
Before
getContributionRecurObjectinline in getIDsAfter
extracted -
Technical Details
it now throws an exception when it fails validation & relies on top level try catch. It does log a little less info in that scenario but I think if that is an issue it would be better to revisit in the main try-catch
Comments