Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/financial#152 Remove unused parameters from BaseIPN->failed signature #18732

Merged
merged 1 commit into from
Oct 11, 2020
Merged

dev/financial#152 Remove unused parameters from BaseIPN->failed signature #18732

merged 1 commit into from
Oct 11, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 10, 2020 •
edited
Loading

Overview

Same as #18730 but for failed

Before

public function failed(&$objects, $transaction = NULL, $input = []) {

Screen Shot 2020-10-11 at 10 51 01 AM

After

public function failed($objects) {

Technical Details

Comments

@civibot
Copy link

civibot bot commented Oct 10, 2020

(Standard links)

@civibot civibot bot added the master label Oct 10, 2020
@eileenmcnaughton eileenmcnaughton changed the title dev/financial#152 Remove unused parameters from BaseIPN->failed signa… dev/financial#152 Remove unused parameters from BaseIPN->failed signature Oct 10, 2020
@seamuslee001 seamuslee001 merged commit ce8e5cf into civicrm:master Oct 11, 2020
@seamuslee001 seamuslee001 deleted the fail branch October 11, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001