dev/core#2110 - Warning "Non-static method CRM_Contact_Page_AJAX::pdfFormat() should not be called statically" when changing the page format on print/merge document

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/2110

1. It's a bit difficult to see the warning because it gets hidden somewhere during the ajax call. You can install the loudnotices extension to see it.
2. Go to admin - communications - print page formats.
3. Add a format. Details don't matter.
4. Search for contributions.
5. Select one and from the actions dropdown choose Thank You letter.
6. Expand the Page Format section and change the format.
7. If you have loudnotices installed you can either check ConfigAndLog or on the network tab in browser dev tools check the response.

Or, just look at the function and see it's not static but it's a routing endpoint as defined at

civicrm-core/CRM/Core/xml/Menu/Contact.xml

Line 310 in 7d6e6b8

<page_callback>CRM_Contact_Page_AJAX::pdfFormat</page_callback>

All the other functions in this file are static too.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Looks fine to me merging