Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/financial#11 Expand unit test to ensure that the correct currency… #18715

Merged
merged 1 commit into from
Oct 9, 2020
Merged

dev/financial#11 Expand unit test to ensure that the correct currency… #18715

merged 1 commit into from
Oct 9, 2020

Conversation

seamuslee001
Copy link
Contributor

… is outputted in the token

Overview

Expands a unit test to cover for the fix by @MegaphoneJon in #18714

Before

Unit test doesn't cover the specific scenario

After

Unit test covers the specific scenario

ping @MegaphoneJon @demeritcowboy @eileenmcnaughton

@civibot
Copy link

civibot bot commented Oct 9, 2020

(Standard links)

@civibot civibot bot added the master label Oct 9, 2020
@seamuslee001 seamuslee001 mentioned this pull request Oct 9, 2020
Merged
@eileenmcnaughton
Copy link
Contributor

nice

@seamuslee001
Copy link
Contributor Author

(note I am expecting the first test run to fail cos it started before i merged the other PR)

@seamuslee001
Copy link
Contributor Author

Expected test fail (Test run had started before fix merged)

@seamuslee001
Copy link
Contributor Author

Jenkins re test this please

@seamuslee001 seamuslee001 merged commit cd20264 into civicrm:master Oct 9, 2020
@seamuslee001 seamuslee001 deleted the dev_financial_11 branch October 9, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has-test master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @eileenmcnaughton