Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParticipantListing Report: only display the View link for web, unhardcode others #18704

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

mlutfy
Copy link
Member

@mlutfy mlutfy commented Oct 7, 2020

Overview

When using the Export to Excel extension (https://civicrm.org/extensions/export-native-excel), the Participant Listing report appends a "View" link to the participant name (which would otherwise further filter the report for that participant). The link does not get appended if we print or export to CSV.

civi-part-list-2020-10-07_17-37

Technical Details

The report had a hardcoded list of "output modes". My undertanding that if the outputMode is empty, then we are displaying on the web.

Various core reports do similar conditions, but they can be a bit difficult to test, so I prefer to ignore them for now.

@civibot
Copy link

civibot bot commented Oct 7, 2020

(Standard links)

@civibot civibot bot added the master label Oct 7, 2020
@eileenmcnaughton
Copy link
Contributor

OK - it's all a bit weird & wonderful but it does seem like this change is at least superficially cleaner from a code poinnt of view & it's unlikely the slight change would affect anyone not using your extension. A bigger rationalisation of that report is a bit scary - it should be possible to use search kit (@colemanw ) to do this sort of report anyway soon

@seamuslee001 seamuslee001 merged commit 2a7b7b2 into civicrm:master Oct 8, 2020
@eileenmcnaughton eileenmcnaughton deleted the partListingOutput branch October 8, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants