Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Minor simplification - don't use a variable for table name #18651

Merged
merged 1 commit into from
Oct 11, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[REF] Minor simplification - don't use a variable for table name

Before

$cfTable = self::getTableName();

& then $cfTable used to refer to civicrm_custom_field

After

civicrm_custom_field used

Technical Details

The old dao->query() method required the table name to be pre-localised but executeQuery does not so it
just adds confusion. I just fixed cfTable (not cfGroup) because I quickly found swapping more than one
out at once got confusing

Comments

the old dao->query() method required the table name to be pre-localised but executeQuery does not so it
just adds confusion. I just fixed cfTable (not cfGroup) because I quickly found swapping more than one
out at once got confusing
@civibot civibot bot added the master label Oct 1, 2020
@civibot
Copy link

civibot bot commented Oct 1, 2020

(Standard links)

@mattwire mattwire merged commit e5c6718 into civicrm:master Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants