[REF] Minor simplification - don't use a variable for table name #18651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Minor simplification - don't use a variable for table name
Before
& then $cfTable used to refer to civicrm_custom_field
After
civicrm_custom_field used
Technical Details
The old dao->query() method required the table name to be pre-localised but executeQuery does not so it
just adds confusion. I just fixed cfTable (not cfGroup) because I quickly found swapping more than one
out at once got confusing
Comments