dev/financial#152 [REF] Parse ids before sending to recur function (minor simplification)

[eileenmcnaughton]

Overview

Minor simplification - parse ids into valid format & pass them into recur, rather than passing them in wrong & 'asking' recur to parse them

Before

parsing of ids into usable array done at the last minute, other values passes around unnecessarily

After

parsing done close to the point where they are derived

Technical Details

The goal here is to make it very clear & visible what is in $ids and objects so we can fix the building of them to only do what is needed,

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@mattwire so I was thinking after these 3 (which would conflict) we STOP PASSING
$objects to completeOrder altogether & pass $contribution instead!

[seamuslee001]

Test fails relate @eileenmcnaughton

CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentRecurNoReceipt
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentRecurSuccess
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentRecurSuccessMultiAuthNetProcessor
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentRecurSuccessSuppliedReceiveDate
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentMembershipRecurSuccess
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentMembershipRecurSuccessNoLeakage
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentMembershipRecurSuccessNoLeakageOnlineThenOffline

[eileenmcnaughton]

Looks like I missed a beat on this one - fortunately jenkins didn't

I'll close this & once the other 2 are merged will switch to passing just contribution (not objects) & then revisit the recurring notification part of this

[eileenmcnaughton]

OK - I fixed it - have at it jenkins

[colemanw]

Makes sense.