pass in "required" value when building preferred_language form element

[adixon]

Overview

As per https://lab.civicrm.org/dev/core/-/issues/1883

When Preferred Language is included in a profile and marked as "required", the form does not respect the 'required' configuration setting (not required in form, not marked as required).

Before

After

Technical Details

Appears to have been a minor coding oversight from a million years ago.

Comments

This might go down as one of the simplest PRs in the history of CiviCRM.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

"This might go down as one of the simplest PRs in the history of CiviCRM."

That was an easy sell on getting me to look. Given the code I feel like I'm happy that you have tested it.

[eileenmcnaughton]

Also given that you came back to this after 3 months & still thought it was needed i'm happy to treat present you as the submitter & past you as the reviewer

[adixon]

Thanks. Given that 3 months ago I can barely remember what my name was, that's a reasonable assumption.

Also, the site I wrote it for has been using it since then without complaint.

[eileenmcnaughton]

@adixon if you ever wish to put up a PR changing your name I'll make @KarinG review it then...