Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if BACKDROP_ROOT is defined already #18545

Merged
merged 2 commits into from
Sep 21, 2020

Conversation

laryn
Copy link
Contributor

@laryn laryn commented Sep 21, 2020

Overview

I'm seeing this in my Backdrop watchdog log:

Notice: Constant BACKDROP_ROOT already defined in CRM_Utils_System_Backdrop->loadBootStrap() (line 526 of /app/modules/civicrm/CRM/Utils/System/Backdrop.php).

We should check to see if the constant is already defined before defining it again.

@civibot
Copy link

civibot bot commented Sep 21, 2020

(Standard links)

@civibot civibot bot added the master label Sep 21, 2020
@eileenmcnaughton
Copy link
Contributor

@laryn this makes sense - jenkin wants you to use 2 space indent though - see the failing check

@herbdool

@laryn
Copy link
Contributor Author

laryn commented Sep 21, 2020

Thanks @eileenmcnaughton this is what comes of editing in the Github UI to submit a PR 😬

@herbdool
Copy link
Contributor

Looks good to me.

@eileenmcnaughton
Copy link
Contributor

unrelated test fail

@eileenmcnaughton eileenmcnaughton merged commit 7c236cb into civicrm:master Sep 21, 2020
@laryn laryn deleted the patch-3 branch September 21, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants